Pull Requests
Pull Requests are used to review code that will be merged from your development branch to the main branch of the repo.
Engineering
Our engineering is underpinned by principles that celebrate both the integrity of code and the ambition to innovate. This manifesto champions excellence, advocates for the adoption of cutting-edge technologies, and fosters an environment of continuous intellectual growth.
On Code Quality
On Cutting-Edge Technologies
On Starting Projects
On Security
Our Tech Stack
On Design Thinking
On Workstation Setup
On Elixir
On Frontend
On Toolchain
On Rails
Title
Start your title with a 3rd-person singular verb (eg, Adds, Fixes) and end with the Ticket ID for which the changes are for.
Adds Save Feature to UserUpdateForm [MYTICKET-12]
If you have additional changes to add to the branch, place [WIP] in front of the name to prevent your branch from being merged until you're finished...
[WIP] Fixes Save Feature to UserUpdateForm
Description
You may use this template for writing a PR Description
## Changes
<!-- Keep Changes short and clear yet complete, avoid leaving out small changes -->
* Adds Save Button to UserUpdateForm
* Submits PUT request to save the form fields to Database
* Displays Popup with Response Message
## Screenshots\Gifs
<!-- Upload Screenshots or Gifs here if changes have a visible effect, avoid uploading images of codes here. -->
## References
<!-- URL related to the Pull Request, such as Jira Ticket -->
* https://myproject.atlassian.net/browse/MyProject-99
Size
Please keep the size of your pull request manageable. Remember that people who review your code are also busy with their own tasks. We recommended a maximum of 800 additions and / or 800 deletions. There will always be certain instances when this isn't enough. For unavoidable BIG pull requests, we would recommend this pattern:
awesome-feature O ---
\ ----- O awesome-feature-frontend
\ ----- O awesome-feature-backend
\ ----- O awesome-feature-misc
Breakdown your main branch (awesome-feature) into mini children branches (awesome-feature-frontend, backend, misc). These children branches are for REVIEWERS only and will not be merged back to the main branch. This way, the people reviewing your code will see smaller glimpses of your BIG pull request. Here is a sample list of commands to break down your awesome-feature:
$ git checkout awesome-feature
$ git checkout -b awesome-feature-backend
$ git reset --soft <first commit of your pull request>
$ git add <all backend files>
$ git commit -m "backend fixes"
Also note that all fixes requested in the children branches will be done in the main branch, then cherry-picked to the affected child branch. We recommend this as a last resort, given the amount of work that you'll be doing. Remember that your pull request is your responsibility. Making the reviewers understand and accept it is part of it.
Resources
• The (written) unwritten guide to pull requests (atlassian.com) • How to Contribute (reactjs.org)
Insights, Forward Thinking.
Dive into our latest musings and discoveries. Our blog is a window to the trends shaping the future and reflections on our journey.
Exploring horizons, sharing insights.
Agile Evolution: Adapting Strategy for Fast-Paced Tech Development
From building minimum-viable-products to managing existing products, we created product teams and managed them within Mashup Garage. We work with companies of different stages and together we built products and launched them.
Designing for Scalability: Engineering Challenges and Strategies
From building minimum-viable-products to managing existing products, we created product teams and managed them within Mashup Garage. We work with companies of different stages and together we built products and launched them.
Innovation at the Intersection: How Diverse Cultures are Shaping Tech
From building minimum-viable-products to managing existing products, we created product teams and managed them within Mashup Garage. We work with companies of different stages and together we built products and launched them.
Connect.
Mashup Garage, a premier software development team, specialises in crafting exceptional products for startups and enterprises. With expertise in React, Elixir/Phoenix, and Ruby on Rails, we deliver solutions that meet your unique needs. Our mission is to bring value backed by decades of technical expertise and global co-founding experience.
What do you need help with?
Build a project
Build a team
Consult
Speak to someone
Expect a guaranteed response from us in 1-2 business days.
United Kingdom
London
Islington, London
+44 738 777 3405
LDN
Philippines
Manila
3F Topy IV Building, 3 Economia Road, Bagumbayan, Quezon City, 1110
+63 917 3084089
MNL